Skip to content

Bug fixes and improvement README #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ma1onso wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bug fixes and improvement README #4

ma1onso wants to merge 6 commits into from

Conversation

@ma1onso
Copy link

@ma1onso ma1onso commented Sep 13, 2018

No description provided.

@ma1onso ma1onso changed the title ignore .idea(pycharm) folder General refactor Sep 14, 2018
@ma1onso ma1onso changed the title General refactor Fix multiples bugs and improvement README Oct 22, 2018
@ma1onso ma1onso changed the title Fix multiples bugs and improvement README Bug fixes and improvement README Oct 22, 2018
@JuanSeBestia
Copy link

JuanSeBestia commented Dec 5, 2018

Thank you, this work

@devepayco
Copy link
Contributor

devepayco commented Jan 28, 2019

Hola @alonsoenrique @JuanSeBestia este Issue ya se encuentra corregido, por favor descargar nuevamente la librería, agradecemos amablemente su reporte

@ma1onso
Copy link
Author

ma1onso commented Jan 28, 2019 •
edited
Loading

@devepayco estuve revisando su rama master y no veo las correcciones que yo sugiero en esa rama. Lo que se debe hacer en este caso es merge de estos cambios en su rama master, si necesitan ayuda para eso, con gusto los puedo ayudar. Adjunto imágenes probando que los cambios de su rama master siguen teniendo los problemas que reporte y solucione.

Rama master:
screenshot from 2019-01-28 14-31-30
screenshot from 2019-01-28 14-31-44

Algunos cambios de este pull request:
screenshot from 2019-01-28 14-31-06

@devepayco
Copy link
Contributor

devepayco commented Jan 28, 2019

@alonsoenrique lamentamos la demora en la solución de este issue puede revisar que ya el código fue agregado, nuestro equipo lo agrego directamente en este commit ee6e77f

@ma1onso
Copy link
Author

ma1onso commented Jan 30, 2019

@devepayco gracias, ahora si agregaron los cambios.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ma1onso @JuanSeBestia @devepayco