Skip to content

Bugfix: golden layout items min width #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlfiyaRF wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bugfix: golden layout items min width #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ca0df5
increased width for tabs
AlfiyaRF Mar 15, 2022
2dad1b5
min width for browser
AlfiyaRF Mar 29, 2022
fb1c086
removed unused isBrowserNarrow
AlfiyaRF Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion client/client/app/shared/components/ngbGoldenLayout/ngbGoldenLayout.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import angular from 'angular';
import { indexOf } from 'lodash';
import baseController from '../../../shared/baseController';

import {PairReadInfo} from '../../utils/events';
Expand Down Expand Up @@ -160,7 +161,13 @@ export default class ngbGoldenLayoutController extends baseController {
if (isBrowser) {
const resizeObserver = new ResizeObserver(entries => {
for (const entry of entries) {
this.projectContext.isBrowserNarrow = entry.target.clientWidth < MIN_BROWSER_WIDTH;
if (entry.target.clientWidth < MIN_BROWSER_WIDTH) {
const elementStyle = stack.element[0].style;
const contentItems = stack.contentItems[0];
const elementWidth = +elementStyle.width.replace('px', '');
const width = MIN_BROWSER_WIDTH + contentItems.container.width - elementWidth;
contentItems.container.setSize(width, elementStyle.height);
}
}
});
resizeObserver.observe(stack.element[0]);
Expand Down
9 changes: 0 additions & 9 deletions client/client/app/shared/projectContext/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ export default class projectContext {

_lastLocalTracks = [];
_localDataset = null;
_isBrowserNarrow = false;

get firstPageVariations() {
return this._firstPageVariations;
Expand Down Expand Up @@ -308,14 +307,6 @@ export default class projectContext {
this._bookmarksFilterIsDefault = value;
}

get isBrowserNarrow() {
return this._isBrowserNarrow;
}

set isBrowserNarrow(value) {
this._isBrowserNarrow = value;
}

get vcfFilter() {
return this._vcfFilter;
}
Expand Down