Add support to save clustering statistics in lsstypes (and other) formats#168
Open
Add support to save clustering statistics in lsstypes (and other) formats#168
Conversation
Owner
Author
|
Ignore the "unit test for WST" commit, which is being reviewed in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the clustering estimator classes produce different kinds of outputs depending on the statistics (collection of correlation/power multipoles, coefficients, etc). Sometimes the data is saved as a simple 1D array (e.g. WST), sometimes as lists of pycorr objects (e.g. density split), etc, which can be confusing.
This PR begins to implement new
savefunctions for the estimator classes, which can be used to save data as we currently are (for retrocompatibility), but more importantly, it allows us to save all statistics in a commonlsstypesformat (https://github.com/adematti/lsstypes), following the new standard for the clustering measurements produced by GQC. It also allows other formats (.nc or .zarr for xarray; only working for WST for now).Output data format is given by the file suffix:
We can then read the data as e.g.