Skip to content

Arrays in cython in python3.12#129

Open
PalPaulD wants to merge 1 commit intocosmodesifrom
cython_fix
Open

Arrays in cython in python3.12#129
PalPaulD wants to merge 1 commit intocosmodesifrom
cython_fix

Conversation

@PalPaulD
Copy link
Collaborator

@PalPaulD PalPaulD commented Jan 5, 2026

The code stopped compiling due to some changes in cython. The arrays types must be specified differently now, this is a small patch that adjusts for this. No functional changes, but now acm package compiles in new cosmodesi env

@SBouchard01
Copy link
Collaborator

Thank you very much !
If it compiles and behaves as expected, could you also remove the commented part ? (We can always revert to a previous version trough git if needed ^^)

I also notice the acm/estimators/galaxy_clustering/src/minkowski.pyx file also has the same formatting, does it breaks the compilation too? (otherwise I'm opening an issue for a later fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants