This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Tokenize search results and highlight the matches in the sidebar#306
Open
thomcc wants to merge 1 commit intoeoger:masterfrom
Open
Tokenize search results and highlight the matches in the sidebar#306thomcc wants to merge 1 commit intoeoger:masterfrom
thomcc wants to merge 1 commit intoeoger:masterfrom
Conversation
thomcc
force-pushed
the
highlight-results
branch
from
b6d5805 to
3e1f44b
Compare
thomcc
force-pushed
the
highlight-results
branch
from
3e1f44b to
788f177
Compare
eoger
suggested changes
Mar 2, 2018
| if (tokens.length === 0) { | ||
| return true; | ||
| } | ||
| let title = normalizeStr(this.title); |
Owner
There was a problem hiding this comment.
How about combining this.title and this.url in a single string?
Owner
|
From IRC: Can you also put |
Owner
|
Also interesting possibility is we want fuzzy search: https://github.com/farzher/fuzzysort |
Contributor
Author
|
Fuzzy search would be better without a doubt. It seemed to me like this was a necessary first step though, but I hadn't considered just using a library for it. |
eoger
added a commit
that referenced
this pull request
May 5, 2018
This takes a different route than #306 by using the fuzzysort library. The filtered tabs are ordered by relevance. In consequence, the drag-and-drop experience during a search might feel inconsistent to the user since the search order != tabs order.
Contributor
|
Should this be closed, since fuzzy searching has been implemented? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By tokenize I just mean allow searching "foo bar" to match "foo baz bar" and such, each word (split on \s+) is checked separately.
The more complex part of this is highlighting them, or really figuring out which parts to highlight. The end result behaves pretty well.