-
Notifications
You must be signed in to change notification settings - Fork 0
DRAFT: agent-server runtime LLM switching #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: agent-sdk-26-llm-switch
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @enyst, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement by enabling runtime switching of Large Language Models (LLMs) for agents within the system. It refines the underlying persistence mechanisms to ensure that LLM changes are correctly saved and restored across sessions, supporting both profile-based and inline LLM configurations. The changes include new API endpoints for both the SDK and the agent-server, along with updated documentation and examples, to provide a flexible and robust solution for dynamic LLM management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and valuable feature: runtime LLM switching for agents. It's a large but well-executed change that simplifies the SDK by removing the previous complex agent reconciliation logic and the OPENHANDS_INLINE_CONVERSATIONS mechanism. The new approach to persistence and conversation restoration is more flexible and powerful. The changes are consistently applied across the SDK, agent-server, examples, and tests. The new documentation and examples are clear and helpful for understanding the new feature. I have a couple of suggestions to improve the maintainability of the new code, but overall, this is an excellent improvement.
12e3643 to
31ea0dd
Compare
6eb0d14 to
dba84fb
Compare
- Remove agent immutability + diff enforcement\n- Add agent-server LLM update endpoints (/llm, /llm/switch)\n- Persist LLM swaps across restart; add tests and examples
31ea0dd to
b6e47cc
Compare
|
Addressed Gemini review: deduped agent-server LLM update wiring via helper and replaced hardcoded restore-time LLM overlay list with a module constant. |
Mirror of upstream OpenHands#1544 for fork AI reviews.