DRAFT: LLM refactor plan + model-info/capabilities initialization design #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
- Avoid inline import; keep imports at top for clarity Co-authored-by: openhands <openhands@all-hands.dev>
- Thin LLM facade with focused modules (formatters, options, tools, transport, invokers) - Future-ready for streaming, async, stateful Responses API - Extract+cache model_info; pure derivations for token limits and capabilities - Group Anthropic-specific logic (cache markers, tokens, reasoning) behind small helpers Co-authored-by: openhands <openhands@all-hands.dev>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…t Anthropic grouping\n\n- clone(): reuse profile only if model/base_url unchanged; otherwise re-resolve\n- LRU cache keyed by (normalized_model, base_url)\n- default http when scheme missing; no extra flags\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…rify Responses path has no Anthropic\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…; keep Chat example minimal\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…ction\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…egments, live switch flow)\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…nfigure of state.agent.llm; no new Agent copies; persistence via base_state save\n\nCo-authored-by: openhands <openhands@all-hands.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design docs for refactoring the LLM module with a focus on simplicity, readability, and future extensibility (streaming, async, stateful Responses API).
Summary
Files
Notes