New Gazebo actions without actor

[adivardi]

Add new actions for Gazebo:
Several actions of upstream use an actor for no real reason. The whole idea of an actor is that the action uses the actor's fields.

In this PR, I add "actorless"-versions of 2 GZ actions (copies of the upstream's actor actions), then modify the actor version to use them.

• Add delete entity and use it in delete_actor
• Add spawn entity and use it in spawn_actor

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Gazebo simulation actions by introducing generic base classes for spawning and deleting entities. This change centralizes common logic, reduces code duplication in actor-specific actions, and introduces new, more general OpenSCENARIO actions for direct entity manipulation within Gazebo. The goal is to improve maintainability and extensibility of the Gazebo integration.

Highlights

• Refactored Gazebo Actions: Introduced generic GazeboDeleteEntity and GazeboSpawnEntity base classes to centralize common logic for managing entities in Gazebo, reducing code duplication.
• Simplified Actor Actions: GazeboDeleteActor and GazeboSpawnActor classes were refactored to inherit from their respective generic entity counterparts, streamlining their implementations.
• New OpenSCENARIO Actions: Added new OpenSCENARIO (OSC) actions, gz_delete_entity and gz_spawn_entity, providing more general interfaces for deleting and spawning any Gazebo entity.
• Updated OSC Definitions: The gazebo.osc file was updated to include the new generic entity actions and to modify existing actor-specific actions to leverage this new generic functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Gazebo actions for spawning and deleting actors by introducing GazeboSpawnEntity and GazeboDeleteEntity base classes. This is a great improvement as it reduces code duplication and improves maintainability. My review includes a few suggestions to further improve the code quality, such as adhering to best practices for class initialization, handling unused parameters, and improving code readability by using f-strings for command construction.