Skip to content

feat(helm): add namespaceOverride support to gateway-helm chart#8281

Open
honarkhah wants to merge 2 commits intoenvoyproxy:mainfrom
honarkhah:main
Open

feat(helm): add namespaceOverride support to gateway-helm chart#8281
honarkhah wants to merge 2 commits intoenvoyproxy:mainfrom
honarkhah:main

Conversation

@honarkhah
Copy link

What type of PR is this?

feat(helm): add namespaceOverride support to gateway-helm chart

What this PR does / why we need it:

Adds a namespaceOverride value to the gateway-helm chart, allowing users to override the namespace for all resources deployed by the chart. This is a common Helm pattern (similar to the existing nameOverride / fullnameOverride) that is especially useful when the chart is used as a sub-chart in an umbrella chart, where the release namespace may differ from the desired deployment namespace.

A new eg.namespace template helper was introduced in _helpers.tpl that returns namespaceOverride if set, falling back to .Release.Namespace. All 15 template files that previously referenced .Release.Namespace directly now use this helper instead.

Changes:

  • Added namespaceOverride: "" to values.tmpl.yaml
  • Added eg.namespace helper to _helpers.tpl
  • Updated all templates (certgen-rbac.yaml, certgen.yaml, envoy-gateway-config.yaml, envoy-gateway-deployment.yaml, envoy-gateway-hpa.yaml, envoy-gateway-poddisruptionbudget.yaml, envoy-gateway-rbac.yaml, envoy-gateway-service.yaml, envoy-gateway-serviceaccount.yaml, infra-manager-rbac.yaml, leader-election-rbac.yaml, namespace.yaml, namespaced-infra-manager-rbac.yaml, envoy-proxy-topology-injector-webhook.yaml, NOTES.txt) to use {{ include "eg.namespace" . }} instead of {{ .Release.Namespace }}

Which issue(s) this PR fixes:
Fixes #8280

Release Notes: Yes

@honarkhah honarkhah requested a review from a team as a code owner February 16, 2026 13:18
@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit e316a56
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/699319205d70950008f470e7

@cnvergence
Copy link
Member

Thanks @honarkhah, maybe let's add the helm test with namespaceOverride in https://github.com/envoyproxy/gateway/tree/main/test/helm/gateway-helm

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.56%. Comparing base (38b0ad1) to head (e316a56).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8281      +/-   ##
==========================================
+ Coverage   73.55%   73.56%   +0.01%     
==========================================
  Files         242      242              
  Lines       36949    36949              
==========================================
+ Hits        27178    27183       +5     
+ Misses       7851     7848       -3     
+ Partials     1920     1918       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add namespaceOverride in values.yaml

2 participants