feat: invalid listener should not block IR#8194
Open
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
Open
feat: invalid listener should not block IR#8194zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zirain
force-pushed
the
TLSRouteInvalidNoMatchingListener
branch
from
79d5334 to
f9d8860
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8194 +/- ##
==========================================
+ Coverage 73.82% 73.84% +0.01%
==========================================
Files 241 241
Lines 36609 36606 -3
==========================================
+ Hits 27027 27032 +5
+ Misses 7677 7670 -7
+ Partials 1905 1904 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
force-pushed
the
TLSRouteInvalidNoMatchingListener
branch
from
f9d8860 to
499c523
Compare
zirain
force-pushed
the
TLSRouteInvalidNoMatchingListener
branch
from
499c523 to
aa7f516
Compare
Member
Author
|
/retest |
arkodg
reviewed
Feb 8, 2026
| name: http-8087 | ||
| protocol: HTTP | ||
| servicePort: 8087 | ||
| - address: null |
Contributor
There was a problem hiding this comment.
will the infra layer be able to gracefully ignore this IR which has protocol unset ?
Member
Author
There was a problem hiding this comment.
There's a check about len of listeners, but Infra didn't care about the listener address.
Member
Author
|
xref: #8244 |
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
TLSRouteInvalidNoMatchingListener
branch
from
aa7f516 to
fe98987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #3673
Find this when debugging TLSRouteInvalidNoMatchingListener, also this should be part of kubernetes-sigs/gateway-api#4425