Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8187 +/- ##
==========================================
- Coverage 73.82% 73.82% -0.01%
==========================================
Files 241 241
Lines 36609 36615 +6
==========================================
+ Hits 27027 27031 +4
Misses 7677 7677
- Partials 1905 1907 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
force-pushed
the
attachedRoutes
branch
from
82facb9 to
5d39f4b
Compare
jukie
reviewed
Feb 7, 2026
arkodg
reviewed
Feb 8, 2026
zirain
force-pushed
the
attachedRoutes
branch
3 times, most recently
from
a8155d4 to
ad7262c
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
attachedRoutes
branch
from
ad7262c to
15a9479
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #8244
Find this during test TLSRoute conformance test TLSRouteInvalidNoMatchingListenerHostname.
The issue is that, if a route is invalid(e.g. hostname no matching),
attachedRoutesshouldn't be increased.