Skip to content

fix: computeHosts doesn't work when listener and route both wildcard #8186

Open
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain:fix-hostname
Open

fix: computeHosts doesn't work when listener and route both wildcard #8186
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain:fix-hostname

Conversation

@zirain
Copy link
Member

@zirain zirain commented Feb 5, 2026

Found this during test TLSRouteHostnameIntersection conformance test, more details could be found here.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner February 5, 2026 06:58
@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit b4ca52d
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69843f8f50b70600087d3593

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.79%. Comparing base (d85a78e) to head (b4ca52d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/helpers.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8186   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files         241      241           
  Lines       36579    36591   +12     
=======================================
+ Hits        26994    27003    +9     
- Misses       7678     7681    +3     
  Partials     1907     1907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain added this to the v1.8.0-rc.1 Release milestone Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant