-
Notifications
You must be signed in to change notification settings - Fork 674
bump Gateway API v1.5.0-rc.1 #8161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zirain
wants to merge
23
commits into
envoyproxy:main
Choose a base branch
from
zirain:e2e-fail-fast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33,873
−15,408
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b44634c
sep e2e gomod
zirain 14608dd
fix cel test
zirain 17dd60b
fix e2e
zirain 8dba4de
fix gen
zirain 0b10f57
fix lint and gen
zirain d763576
fix test
zirain 988acaa
revert
zirain 37ca642
skip ListenerSet
zirain add9517
skip more
zirain 0dca82c
skip tlsroute
zirain 72a1fe9
skip more test
zirain d424560
fix RunTest
zirain 4ab3c99
support FailFast
zirain 015d419
bump golang 1.25.7
zirain 30f44a7
fix
zirain 096a191
bump Gateway API v1.5.0-rc.1
zirain 0e211a9
fix
zirain fd404a8
remove FailFast
zirain 84ba787
skip more
zirain 4f3c337
Merge branch 'main' into e2e-fail-fast
zirain 3ff3fff
gomod tidy
zirain 329490a
fix gen
zirain c8744e0
skip ListenerSet
zirain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6,018 changes: 3,710 additions & 2,308 deletions
6,018
charts/gateway-crds-helm/templates/experimental-gatewayapi-crds.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XListenerSet promote to
v1in Gateway API v1.5Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing this is the breaking change because even if a user wants to stay on XListenerSet, then cant ? and must migrate to ListenerSet when upgrading to v1.8 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, If we need rethink about this in the future, do we need to support X API.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for what it's worth, we (cert-manager) have decided to do a clean cut upgrade to ListenerSet as opposed to keeping both resources. There was a discussion on whether to keep the X resources around in 1.5: https://kubernetes.slack.com/archives/CR0H13KGA/p1770328007249819
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to removing
XListenerSetsupport from 1.8 since we've already set expectations in theGatewayAPISettingsthatThese APIs are experimental today and are subject to change or removal as they mature.Maintaining both
XListenerSetandListenerSetwould add quite a bit of ongoing overhead, and it might not be worth keeping both around.