feat(helm): add namespaceOverride support to gateway-helm chart#8281
Open
honarkhah wants to merge 2 commits intoenvoyproxy:mainfrom
Open
feat(helm): add namespaceOverride support to gateway-helm chart#8281honarkhah wants to merge 2 commits intoenvoyproxy:mainfrom
namespaceOverride support to gateway-helm chart#8281honarkhah wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Member
|
Thanks @honarkhah, maybe let's add the helm test with namespaceOverride in https://github.com/envoyproxy/gateway/tree/main/test/helm/gateway-helm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8281 +/- ##
==========================================
+ Coverage 73.55% 73.56% +0.01%
==========================================
Files 242 242
Lines 36949 36949
==========================================
+ Hits 27178 27183 +5
+ Misses 7851 7848 -3
+ Partials 1920 1918 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat(helm): add
namespaceOverridesupport to gateway-helm chartWhat this PR does / why we need it:
Adds a
namespaceOverridevalue to thegateway-helmchart, allowing users to override the namespace for all resources deployed by the chart. This is a common Helm pattern (similar to the existingnameOverride/fullnameOverride) that is especially useful when the chart is used as a sub-chart in an umbrella chart, where the release namespace may differ from the desired deployment namespace.A new
eg.namespacetemplate helper was introduced in_helpers.tplthat returnsnamespaceOverrideif set, falling back to.Release.Namespace. All 15 template files that previously referenced.Release.Namespacedirectly now use this helper instead.Changes:
namespaceOverride: ""tovalues.tmpl.yamleg.namespacehelper to_helpers.tplcertgen-rbac.yaml,certgen.yaml,envoy-gateway-config.yaml,envoy-gateway-deployment.yaml,envoy-gateway-hpa.yaml,envoy-gateway-poddisruptionbudget.yaml,envoy-gateway-rbac.yaml,envoy-gateway-service.yaml,envoy-gateway-serviceaccount.yaml,infra-manager-rbac.yaml,leader-election-rbac.yaml,namespace.yaml,namespaced-infra-manager-rbac.yaml,envoy-proxy-topology-injector-webhook.yaml,NOTES.txt) to use{{ include "eg.namespace" . }}instead of{{ .Release.Namespace }}Which issue(s) this PR fixes:
Fixes #8280
Release Notes: Yes