Add tonya11en to CODEOWNERS for LR, random, and common LB#31171
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Dec 5, 2023
Merged
Add tonya11en to CODEOWNERS for LR, random, and common LB#31171alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Tony Allen <tony@allen.gg>
Member
|
/assign @wbpcode |
wbpcode
approved these changes
Dec 5, 2023
Member
|
cc @alyssawilk |
Member
Author
Of course, I'm happy to help. |
alyssawilk
approved these changes
Dec 5, 2023
delphisfang
pushed a commit
to delphisfang/envoy
that referenced
this pull request
Dec 10, 2023
…#31171) Signed-off-by: Tony Allen <tony@allen.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a large number of attempted changes to the LB algorithms centered around the EDF scheduler, P2C-related changes to the least request balancer, etc. I'd like to be notified of changes in this area because it's difficult to weigh in after things have already been merged. See the following discussions around this:
There are also numerous slack conversations that are related, which I can provide links to if requested.
Changes to the LB scheduler and least request algorithm have subtle bugs that can be introduced because of the change to selection probabilities in various cases. I'm attempting to get #30818 merged, but being added to the owners file would help get notified sooner.