WIP fill in style guide with current Ember standards#32
WIP fill in style guide with current Ember standards#32pixelhandler wants to merge 1 commit intomasterfrom
Conversation
|
|
||
| ## Tailwind CSS | ||
|
|
||
| - Using important when tailwind css is overwritten or adding to scss? |
There was a problem hiding this comment.
@kamal @esbanarango any thoughts on when to add to scss vs use tailwind
|
|
||
| ### Actions | ||
|
|
||
| - Triggering single boolean property, use `action` or `mut`? |
There was a problem hiding this comment.
mut has old backwards compatibility for v1 days, I think. it sets and reads.
docs:
articles:
There was a problem hiding this comment.
Side note: I find (fn (mut this.booleanishProperty) true|false) a better alternative to actions that toggle a property. Especially if its a property on a controller which lives on after you leave its route. I've seen issues where showModal is still true when you revisit the route via back button etc.
|
|
||
| ## Templates | ||
|
|
||
| ### Actions |
There was a problem hiding this comment.
Perhaps Need to document use of fn and @action for replacing old computed props
|
|
||
| ### Component Args | ||
|
|
||
| - constructor with setting local props, args with objects, chain in template or getter in JS? |
There was a problem hiding this comment.
need to discuss these two again
|
@CodeOfficer can you add comment on https://github.com/envoy/garaje/pull/9770/files to this ? |
2 participants
PLEASE HALP :)