Skip to content

Conversation

@morremeyer
Copy link
Member

This fixes an issue where if there are match rules with an identical matcher in multiple budgets, the match rule from the wrong budget could be used by the mapping process on import.

This was caused by a missing clause in the SQL statement that led to match rules being considered multiple times.

With this fix, the processing of match rules is also significatly faster now, since a match rule is only considered once.

@morremeyer morremeyer requested a review from a team as a code owner December 15, 2025 01:09
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (8c275f4) to head (7c7bf04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   79.54%   79.54%   -0.01%     
==========================================
  Files          57       57              
  Lines        3828     3827       -1     
==========================================
- Hits         3045     3044       -1     
  Misses        638      638              
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This fixes an issue where if there are match rules with an identical matcher in multiple budgets, the match rule from the wrong budget could be used by the mapping process on import.

This was caused by a missing clause in the SQL statement that led to match rules being considered multiple times.

With this fix, the processing of match rules is also significatly faster now, since a match rule is only considered once.
@morremeyer morremeyer force-pushed the fix/match-rule-account-match branch from 0ff3c06 to 7c7bf04 Compare December 15, 2025 01:11
@morremeyer morremeyer merged commit 96f120c into main Dec 15, 2025
6 checks passed
@morremeyer morremeyer deleted the fix/match-rule-account-match branch December 15, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants