Merged
Conversation
akhilkumarpilli
force-pushed
the
v2.5.0-upgrade
branch
from
bc79dd0 to
b2a410e
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## releases/v2.x #196 +/- ##
================================================
Coverage ? 53.83%
================================================
Files ? 28
Lines ? 2597
Branches ? 0
================================================
Hits ? 1398
Misses ? 1094
Partials ? 105 🚀 New features to boost your workflow:
|
* add minimum-gas-prices restriction * update minimum-gas-prices to 25upasg * update min-gas-price to 12.5upasg
* WIP: migrate multisig addresses * WIP: done almost implementation * update handler and add test * WIP: fixing tests * fix tests * Update delegations code and fix tests * update vesting times * update start time * update migrations details * fix lint
anilcse
changed the title
anilcse
reviewed
Apr 16, 2025
| if minGasPrices.AmountOf(baseDenom).LT(sdk.MustNewDecFromStr(defaultMinGasPrice)) { | ||
| panic(fmt.Sprintf("minimum-gas-prices value in app.toml should be greater than or equal to %s%s", | ||
| defaultMinGasPrice, baseDenom)) | ||
| } |
Collaborator
There was a problem hiding this comment.
Should we do this at server side (inside ante or somewhere) to handle it better for gRPC, RPC calls as well?
anilcse
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the software upgrade to update IBC, Cosmwasm deps from upstream and also the changes required for the governance proposals https://atomscan.com/passage/votes/15, https://atomscan.com/passage/votes/16, https://atomscan.com/passage/votes/17
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change