Add CI and lint GitHub Actions workflows#2
Merged
alishakawaguchi merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Add CI workflow (unit tests with race detector + build verification) and lint workflow (gofmt check + golangci-lint with inline PR annotations) triggered on PRs and pushes to main. Add .golangci.yaml v2 config with curated linter set adapted from devenv/cli. Fix existing lint issues: unused types, unchecked json.Marshal errors, formatting, and minor code quality improvements. Add .gitignore for runtime artifacts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 8e58bb2aa1e6
CI golangci-lint v2.11.3 flagged G703 (path traversal via taint) for controlled file paths and goconst for "darwin" in runtime.GOOS switches. Exclude G703 (paths are constructed from controlled inputs) and raise goconst min-occurrences to 5 to avoid flagging idiomatic patterns. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 93daed613361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml): unit tests with race detector + build verification on PRs and pushes to mainlint.yml): gofmt formatting check + golangci-lint v2 with inline PR annotations (per-module).golangci.yaml: curated linter set adapted from devenv/cli with appropriate exclusions for CLI tools and e2e test infra.gitignore: ignore.entire/runtime data and built binariesjson.Marshalerrors, formatting alignment, dead code removalTest plan
gofmt -l .returns empty (all files formatted)golangci-lint run ./...passes inagents/entire-agent-kiro(0 issues)golangci-lint run ./...passes ine2e(0 issues)go test -race -count=1 ./...passes inagents/entire-agent-kiro(2/2 packages)go build -o /dev/null ./cmd/entire-agent-kirosucceeds🤖 Generated with Claude Code
Note
Low Risk
Low risk: mostly adds GitHub Actions workflows and lint configuration; code changes are small, lint-driven cleanup (error handling and dead code removal) with minimal behavior impact.
Overview
Adds GitHub Actions automation: a
CIworkflow to rungo test -raceand a build check foragents/entire-agent-kiro, plus aLintworkflow that enforcesgofmtand runsgolangci-lintfor bothagents/entire-agent-kiroande2e.Introduces a repo-wide
.golangci.yamland updates.gitignoreto exclude.entire/runtime data and the builtentire-agent-kirobinary. To satisfy the new linting, it also tightens error handling aroundjson.Marshal, removes unused execution-index types, and makes minor cleanup/refactors (e.g.,stubSessionIDconstant reuse and simpler session file path building).Written by Cursor Bugbot for commit 05e2acb. Configure here.