Skip to content

feat: v2 dual-write for checkpoints behind feature flag #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfleidi wants to merge 18 commits into
base: main
Choose a base branch
from
+1,784 −7
Open

feat: v2 dual-write for checkpoints behind feature flag #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0eb9599
feat: add v2 checkpoint ref name constants
pfleidi Mar 23, 2026
594f54c
feat: add V2Store skeleton with ref management helpers
pfleidi Mar 23, 2026
f343da1
feat: add V2GitStore.writeCommittedMain for metadata writes to /main ref
pfleidi Mar 23, 2026
96aff83
feat: add V2GitStore.writeCommittedFullTranscript
pfleidi Mar 23, 2026
e79e4a2
Merge branch 'main' of github.com:entireio/cli into feat/checkpoints-…
pfleidi Mar 23, 2026
0c3244c
feat: add V2GitStore.WriteCommitted composing /main and /full/current…
pfleidi Mar 23, 2026
4c754d4
Write content hash to ephemeral /full/current ref
pfleidi Mar 23, 2026
dc3beb0
feat: wire v2 dual-write into CondenseSession, gated by checkpoints_v2
pfleidi Mar 23, 2026
6217021
feat: add V2GitStore.UpdateCommitted and wire into stop-time
pfleidi Mar 23, 2026
2da036a
test: add integration tests for v2 dual-write workflow
pfleidi Mar 23, 2026
20a37d5
fix: add omitempty to SessionFilePaths to avoid empty strings in v2
pfleidi Mar 23, 2026
66841b2
fix: Remove redundant validation code
pfleidi Mar 23, 2026
860efa8
Only mark optional attributes as `omitempty`
pfleidi Mar 23, 2026
1a5840d
Revert changes to unrelated file
pfleidi Mar 24, 2026
25b2d9a
fix: address PR review feedback on comments, logging, and context sco…
pfleidi Mar 24, 2026
10ab903
Remove outdated comment lines
pfleidi Mar 24, 2026
65d73a0
Evaluate v2 strategy settings only once
pfleidi Mar 24, 2026
438e156
Apply suggestion from @Copilot
pfleidi Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/entire/cli/checkpoint/checkpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,8 @@ func (m CommittedMetadata) GetTranscriptStart() int {
// Used in CheckpointSummary.Sessions to map session IDs to their file locations.
type SessionFilePaths struct {
Metadata string `json:"metadata"`
Transcript string `json:"transcript"`
ContentHash string `json:"content_hash"`
Transcript string `json:"transcript,omitempty"`
ContentHash string `json:"content_hash,omitempty"`
Copy link
Contributor Author

@pfleidi pfleidi Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These attributes might not be set going forward. Omitting them in such a case made sense to me.

Copy link
Contributor

@computermode computermode Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would Transcript be missing but Prompt isn't? Should Prompt be omitempty too? (Also, is this for the sub-agent case? Or is there some other case you had in mind?)

Copy link
Contributor Author

@pfleidi pfleidi Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original thought was that by moving the full transcript to the /full/* refs we wouldn't need this anymore unless a checkpoint was pinned. Given that these attributes were only used for the full transcripts we should be okay omitting them unless checkpoints are pinned down the road.

Your comment brought up a few more questions, though:

  • Do we want this attribute to point to the compactedtranscript.jsonl file instead?
  • Do we want to introduce new attributes for compacted transcripts and their hashes?
  • Do we want a way to refer to objects in the /full/* namespace to somehow make the lookup simpler?

Let's take a look at those a bit more closely tomorrow.

Prompt string `json:"prompt"`
}

Expand Down
Loading
Loading