Handle path filtering and general other filtering #758
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package checkpoint | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/entireio/cli/cmd/entire/cli/agent/types" | ||
| "github.com/entireio/cli/cmd/entire/cli/checkpoint/id" | ||
| "github.com/entireio/cli/cmd/entire/cli/filter" | ||
|
|
||
| "github.com/go-git/go-git/v6/plumbing" | ||
| ) | ||
|
|
||
| // SmudgeSessionContent applies the smudge filter to transcript and prompt | ||
| // fields of a SessionContent in place. Safe to call with nil content or pipeline. | ||
| func SmudgeSessionContent(content *SessionContent, pipeline *filter.Pipeline) { | ||
| if content == nil || pipeline == nil { | ||
| return | ||
| } | ||
| content.Transcript = pipeline.Smudge(content.Transcript) | ||
| content.Prompts = pipeline.SmudgeString(content.Prompts) | ||
| } | ||
|
|
||
| // ReadSessionContentForDisplay reads a session's content and applies the smudge | ||
| // filter so stored placeholders are replaced with machine-specific paths. | ||
| // Use this for user-facing output; use ReadSessionContent for internal operations. | ||
| func (s *GitStore) ReadSessionContentForDisplay(ctx context.Context, checkpointID id.CheckpointID, sessionIndex int) (*SessionContent, error) { | ||
| content, err := s.ReadSessionContent(ctx, checkpointID, sessionIndex) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| SmudgeSessionContent(content, filter.FromContext(ctx)) | ||
| return content, nil | ||
| } | ||
|
|
||
| // ReadLatestSessionContentForDisplay is the display variant of ReadLatestSessionContent. | ||
| func (s *GitStore) ReadLatestSessionContentForDisplay(ctx context.Context, checkpointID id.CheckpointID) (*SessionContent, error) { | ||
| content, err := s.ReadLatestSessionContent(ctx, checkpointID) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| SmudgeSessionContent(content, filter.FromContext(ctx)) | ||
| return content, nil | ||
| } | ||
|
|
||
| // GetSessionLogForDisplay is the display variant of GetSessionLog. | ||
| func (s *GitStore) GetSessionLogForDisplay(ctx context.Context, cpID id.CheckpointID) ([]byte, string, error) { | ||
| transcript, sessionID, err := s.GetSessionLog(ctx, cpID) | ||
| if err != nil { | ||
| return nil, "", err | ||
| } | ||
| pipeline := filter.FromContext(ctx) | ||
| return pipeline.Smudge(transcript), sessionID, nil | ||
| } | ||
|
|
||
| // LookupSessionLogForDisplay is a convenience function that opens the repository | ||
| // and retrieves a smudged session log by checkpoint ID. | ||
| func LookupSessionLogForDisplay(ctx context.Context, cpID id.CheckpointID) ([]byte, string, error) { | ||
| transcript, sessionID, err := LookupSessionLog(ctx, cpID) | ||
| if err != nil { | ||
| return nil, "", err | ||
| } | ||
| pipeline := filter.FromContext(ctx) | ||
| return pipeline.Smudge(transcript), sessionID, nil | ||
| } | ||
|
|
||
| // GetTranscriptFromCommitForDisplay is the display variant of GetTranscriptFromCommit. | ||
| func (s *GitStore) GetTranscriptFromCommitForDisplay(ctx context.Context, commitHash plumbing.Hash, metadataDir string, agentType types.AgentType) ([]byte, error) { | ||
| transcript, err := s.GetTranscriptFromCommit(ctx, commitHash, metadataDir, agentType) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| pipeline := filter.FromContext(ctx) | ||
| return pipeline.Smudge(transcript), nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyMetadataDir is documented as being used for “task checkpoints, subagent transcripts, etc.”, but it passes a nil filter pipeline into createRedactedBlobFromFile. This means any absolute paths inside those copied metadata files (e.g., task prompts, agent-*.jsonl) will bypass the new clean filter and be committed un-normalized, undermining the path/privacy filtering behavior elsewhere in the PR. Consider constructing a pipeline once (like in writeSessionToSubdirectory) and passing it through here, or selectively enabling filtering for transcript/prompt-like metadata files while keeping it disabled for files that must remain byte-identical.