Skip to content

feat: add entire stop command#739

Open
peyton-alt wants to merge 4 commits intomainfrom
feat/entire-stop
Open

feat: add entire stop command#739
peyton-alt wants to merge 4 commits intomainfrom
feat/entire-stop

Conversation

@peyton-alt
Copy link
Contributor

@peyton-alt peyton-alt commented Mar 19, 2026

Adds entire stop to manually mark one or more active sessions as ended,
preventing future checkpoint leakage without waiting for the agent to stop
naturally.

Pure state mutation — no writes to the checkpoints branch, no condensation.
The existing PostCommit hook handles any remaining condensation on the next
commit.

Flags: --session , --all (worktree-scoped), -f/--force

Output

Session with a committed checkpoint:
✓ Session 2026-03-19-demo-checkpoint stopped.
Checkpoint: a3b2c4d5e6f7

Session with uncommitted work:
✓ Session 2026-03-19-demo-work stopped.
Work will be captured in your next checkpoint.

Session with no work:
✓ Session 46f9e86a-02c2-46c8-a733-e4323cb5c2cb stopped.
No work recorded.

Already stopped:
Session 2026-03-19-demo-work is already stopped.

Not found:
Session not found.

No active sessions:
No active sessions.


Note

Medium Risk
Adds a new CLI command that mutates on-disk session state (marking sessions as ENDED) and includes interactive selection/confirmation paths, so mistakes could prematurely end sessions or affect worktree scoping.

Overview
Introduces a new entire stop command that manually marks session state as ENDED (without writing checkpoints), supporting --session <id>, worktree-scoped --all, and -f/--force to skip confirmation.

Implements interactive selection/confirmation flows (single-session prompt or multi-select when multiple sessions are active), and adds unit tests covering main stop paths and error cases. Documentation is updated in README.md and the changelog to include the new command.

Written by Cursor Bugbot for commit f14859a. Configure here.

Adds `entire stop` to manually mark one or more active sessions as ended,
preventing future checkpoint leakage without waiting for the agent to stop
naturally or for a SessionStop lifecycle hook.

Pure state mutation — no writes to the checkpoints branch, no condensation.
The existing PostCommit hook handles any remaining condensation on the next commit.

Flags: --session <id>, --all (worktree-scoped), --force/-f
TUI multi-select for 2+ sessions; confirmation prompt for single session.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 19, 2026 22:54
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new entire stop command to manually mark one or more sessions as ended (state-only mutation) to prevent further checkpoint leakage without waiting for the agent lifecycle to naturally close the session.

Changes:

  • Introduces entire stop with --session, --all (worktree-scoped), and --force flows, including interactive selection when multiple sessions exist.
  • Adds unit tests covering the non-interactive stop flows and common error cases.
  • Documents the new command in README.md and CHANGELOG.md, and wires it into the root command.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
README.md Adds entire stop to the command list.
cmd/entire/cli/stop.go Implements the stop command logic (single/all/multi-select) and output messaging.
cmd/entire/cli/stop_test.go Adds unit tests for stop behavior (force, flags, not-found, non-git repo, etc.).
cmd/entire/cli/root.go Registers the new stop subcommand.
CHANGELOG.md Notes the addition of entire stop.

peyton-alt and others added 3 commits March 19, 2026 16:22
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ire stop

- stopSelectedSessions: print ✗ per failed session to stderr so batch
  failures are visible immediately, not just as a joined error at the end
- stopSessionAndPrint: wrap markSessionEnded error with session ID for
  context in both single and batch stop paths
- runStopMultiSelect: warn and skip sessions concurrently removed between
  TUI render and confirmation; guard empty toStop after filtering
- filterActiveSessions: add nil guard; document intentional dual-check
  vs status.go's EndedAt-only filter
- handleFormCancellation: treat huh.ErrTimeout same as ErrUserAborted;
  wrap unexpected errors with action name for context
- --session flag description: note it is not scoped to current worktree
- tests: add TestStopCmd_AllFlag_ExcludesOtherWorktrees,
  TestStopCmd_AllFlag_NoActiveSessions, TestStopSelectedSessions_StopsAll
  (replaces non-executing cop-out multi-select test); add PhaseActive
  coverage to filter unit test; rename SingleSession_Force to clarify
  empty-WorktreePath intent; add ErrTimeout case to utils_test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Explicitly passing a session ID is already a deliberate action — no
confirmation prompt needed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@peyton-alt peyton-alt marked this pull request as ready for review March 20, 2026 19:05
@peyton-alt peyton-alt requested a review from a team as a code owner March 20, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants