Entgql: Determine required fields by Nillable not Optional #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entity optional fields means the field is not required for entity creation, but the field always has a value (the Go default when not specified) when the entity is queried. Nillable, not optional should be used to determine if a type's field is required.
Contributor
Author
|
I misunderstood how Optional() works. I didn't realize these fields were created as nullable in the database and that the gqlgen code receives the potentially null value and not the zero value as accessible from the generated ent type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional fields are fields not required for entity creation. However, unless those fields are also Nillable, querying the entity will always provide a value for optional fields. Nillable, not Optional, should determine which type fields are marked as required in the generated GraphQL schema.