Skip to content

(feat): Added delete subname#308

Open
Malak67 wants to merge 6 commits intofeature/fet-1885-ensjs-refactorfrom
feat/delete-subname
Open

(feat): Added delete subname#308
Malak67 wants to merge 6 commits intofeature/fet-1885-ensjs-refactorfrom
feat/delete-subname

Conversation

@Malak67
Copy link

@Malak67 Malak67 commented Feb 12, 2026

No description provided.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 12, 2026

Open in StackBlitz

npm i https://pkg.pr.new/ensdomains/ensjs/@ensdomains/ensjs@308

commit: ef8d0c7

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 14.63415% with 315 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.38%. Comparing base (e51507c) to head (3f76e00).

Files with missing lines Patch % Lines
...ages/ensjs/src/actions/wallet/v2/deleteSubnames.ts 0.00% 153 Missing and 1 partial ⚠️
...kages/ensjs/src/actions/wallet/v2/deleteSubname.ts 0.00% 152 Missing and 1 partial ⚠️
packages/ensjs/src/contracts/index.ts 0.00% 6 Missing ⚠️
packages/ensjs/src/exports/wallet/v2.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           feature/fet-1885-ensjs-refactor     #308      +/-   ##
===================================================================
- Coverage                            64.27%   63.38%   -0.89%     
===================================================================
  Files                                  167      169       +2     
  Lines                                20240    20609     +369     
  Branches                               759      761       +2     
===================================================================
+ Hits                                 13009    13063      +54     
- Misses                                7183     7496     +313     
- Partials                                48       50       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Malak67 Malak67 marked this pull request as draft February 13, 2026 10:00
@Malak67 Malak67 marked this pull request as ready for review February 20, 2026 11:07
@Malak67 Malak67 requested a review from v1rtl February 20, 2026 11:07
@v1rtl
Copy link
Collaborator

v1rtl commented Feb 21, 2026

Lint is failing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants