Open
Conversation
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Collaborator
|
Test fail with an unrelated error, but otherwise seems fine. The main branch isn't the one that will be used in the future but I suppose we can backport it to the refactor branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a resolved primary name is not normalised, the result should be null or an error, rather than normalising the output. this was theoretically being tested already but
createSubnameandsetAddressRecordboth use thenamehashfunction in ensjs itself, which normalises all labels, and we weren't testing for the error output in strict mode, just that the result is null.changes:
getName. if false (not normalised), there is a newNameNotNormalisedErrorthat can be thrown in strict mode, or non strict will returnnull.writeContract+ viem'snamehashto avoid the normalisation in thenamehashfrom ensjswaitForTransactionnow checks that a transaction was successful in it's receipt