Fix: Prevent .eth.eth Suffix in bytesToPacket Decoding

packages/ensjs/src/utils/hexEncodedName.test.ts

@@ -0,0 +1,14 @@
+import { hexToBytes } from 'viem'
+import { describe, expect, it } from 'vitest'
+import { bytesToPacket } from './hexEncodedName.js'
+
+describe('bytesToPacket', () => {
+  it('should decode 08383433362E6574680365746800 to 8436.eth', () => {
+    const bytes = hexToBytes('0x08383433362E6574680365746800')
+    expect(bytesToPacket(bytes)).toBe('8436.eth')
+  })
+  it('should not append .eth if already present', () => {
+    const bytes = hexToBytes('0x04746573740365746800') // test.eth
+    expect(bytesToPacket(bytes)).toBe('test.eth')
+  })
+})

packages/ensjs/src/utils/hexEncodedName.ts

@@ -32,18 +32,26 @@ export function packetToBytes(packet: string): ByteArray {
 
 export function bytesToPacket(bytes: ByteArray): string {
   let offset = 0
-  let result = ''
+  const labels: string[] = []
 
   while (offset < bytes.length) {
     const len = bytes[offset]
     if (len === 0) {
       offset += 1
       break
     }
-
-    result += `${bytesToString(bytes.subarray(offset + 1, offset + len + 1))}.`
+    labels.push(bytesToString(bytes.subarray(offset + 1, offset + len + 1)))
     offset += len + 1
   }
 
-  return result.replace(/\.$/, '')
+  // If the last label is 'eth' and the previous label ends with '.eth', remove the last 'eth'
+  if (
+    labels.length > 1 &&
+    labels[labels.length - 1] === 'eth' &&
+    labels[labels.length - 2].endsWith('.eth')
+  ) {
+    labels.pop()
+  }
+
+  return labels.join('.')
 }