Skip to content

Refactor Registry Metadata#253

Draft
adraffy wants to merge 3 commits intomainfrom
feat/new-metadata
Draft

Refactor Registry Metadata#253
adraffy wants to merge 3 commits intomainfrom
feat/new-metadata

Conversation

@adraffy
Copy link
Member

@adraffy adraffy commented Mar 19, 2026

  • removed IRegistryMetadata
  • removed MetadataMixin
  • removed BaseUriRegistryMetadata
  • removed SimpleRegistryMetadata
  • removed metadata from all constructors
  • added IRegistryURIRenderer
  • changed PermissionedRegistry
    • added ROLE_SET_URI and ROLE_SET_URI_ADMIN
    • added setDefaultURI(uriData)
    • added setURI(anyId, uriData)
    • added event URIChanged(tokenId, uriData, sender)
    • added uri(tokenId) to use rendering logic

A renderer address is embedded into uriData as abi.encodePacked(uint8(1), address) otherwise its interpreted as a literal URI string.

  • this is kinda weird?
  • could use 2 typed setters? and use mutually exclusive properties on Entry
  • that would make 4 setters... setDefaultURI(...) = setURI(0, ...) would make it 2 again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant