Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of OAuth2 and OpenID Connect (OIDC) authentication in the
oapiclient library, making it easier to configure and automatically discover token endpoints from OIDC provider metadata. The most significant changes include setting a sensible default for the OpenID Connect configuration URL, dynamically retrieving the OAuth2 token endpoint from OIDC metadata, and refactoring related utility methods for clarity and correctness.Authentication and OIDC Improvements:
open_id_connect_urlparameter in the client is now set by default to".well-known/openid-configuration", making OIDC discovery automatic unless explicitly overridden.open_id_connect_urlto clarify its usage and link to the OIDC discovery specification.Refactoring and Code Quality:
_get_oauth2_token_urland_get_open_id_connect_urlmethods for clarity, removing redundant variables and ensuring correct logic for finding token URLs and OIDC configuration endpoints. [1] [2] [3]client.pyby grouping and addingurljointo support relative OIDC configuration URLs.Versioning:
2.5.0to reflect these new features and improvements.