Skip to content

build: io: make oe2 of DDRTristate optional#2068

Merged
enjoy-digital merged 1 commit intoenjoy-digital:masterfrom
VOGL-electronic:ddrtristate_oe2_optional
Dec 4, 2024
Merged

build: io: make oe2 of DDRTristate optional#2068
enjoy-digital merged 1 commit intoenjoy-digital:masterfrom
VOGL-electronic:ddrtristate_oe2_optional

Conversation

@maass-hamburg
Copy link
Contributor

make oe2 of DDRTristate optional.

@maass-hamburg
Copy link
Contributor Author

this m-labs/migen#292 should be merged in migen before, so it wont raise a TypeError, when oe1 and oe2 are a _Slice

@enjoy-digital
Copy link
Owner

Thanks @maass-hamburg for looking at this. We are currently not using upstream migen due to change to pyproject.toml for the installation so would also need to fix this if m-labs/migen#292 is merged to use it.

@maass-hamburg
Copy link
Contributor Author

Thanks @maass-hamburg for looking at this. We are currently not using upstream migen due to change to pyproject.toml for the installation so would also need to fix this if m-labs/migen#292 is merged to use it.

@enjoy-digital and what exactly is the problem with the pyproject.toml in migen?
We need that fix also for #2060 so we can use the DDRTristate when oe1 and oe2 are of the type _Slice. It being that, would be the most common way to use it wenn it is use for something with multiplie lanes, like in LIteSPI.

@maass-hamburg
Copy link
Contributor Author

@enjoy-digital the part that needs m-labs/migen#292 and #2073 is now separated into #2074

the difference is that: 46be90e

make oe2 of DDRTristate optional.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@maass-hamburg maass-hamburg force-pushed the ddrtristate_oe2_optional branch from 37ac79b to c1733ea Compare October 1, 2024 10:11
@maass-hamburg
Copy link
Contributor Author

@enjoy-digital you might want to take another look. This now don't require the change in migen.

@enjoy-digital enjoy-digital merged commit a32096e into enjoy-digital:master Dec 4, 2024
@enjoy-digital
Copy link
Owner

Thanks @maass-hamburg!

@maass-hamburg maass-hamburg deleted the ddrtristate_oe2_optional branch May 21, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants