Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Conversation

@leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Mar 20, 2025

PR Type

  • Enhancement

Description

  • update canary version constants

  • update enjin production versions

  • adjust network spec mapping values

  • reorganize exports in constant files


Changes walkthrough 📝

Relevant files
Enhancement
5 files
matrix.dart
update canary version references                                                 
+5/-1     
enjin.dart
update production latest and specs                                             
+3/-1     
general.dart
update network spec version mappings                                         
+2/-2     
production.dart
adjust exports order and new version                                         
+3/-2     
canary.dart
add new canary export files                                                           
+2/-0     
Additional files
3 files
v1050.dart +2/-0     
v1021.dart +2/-0     
v1022.dart +2/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @leonardocustodio leonardocustodio self-assigned this Mar 20, 2025
    @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consistency Check

    Review the updated spec version constants to ensure that returning 1050 for the enjin-related networks and 1022 for canary networks are consistent and intentional across the codebase.

    int getLatestSpecVersion(network) {
      if (network == 'enjin-relaychain') {
        return 1050;
      }
      if (network == 'canary-relaychain') {
        return 1050;
      }
      if (network == 'canary' || network == 'canary-matrixchain') {
        return 1022;
      }
      return 1014;
    }
    Version Export

    Verify that the newly added exports (v1050, v110, and v120) are in line with the project's versioning strategy and that no export conflicts or omissions occur.

    export 'v1050.dart';
    export 'v110.dart';
    export 'v120.dart';

    @leonardocustodio leonardocustodio merged commit 2ceec79 into master Mar 20, 2025
    1 check passed
    @leonardocustodio leonardocustodio deleted the feature/PLA-2220/metadata branch March 20, 2025 11:20
    @github-actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

    Development

    Successfully merging this pull request may close these issues.

    2 participants