[Neoforge] Improve compatibility with third person mods#206
Open
Exopandora wants to merge 1 commit intoenjarai:stonecutter/1.21from
Open
[Neoforge] Improve compatibility with third person mods#206Exopandora wants to merge 1 commit intoenjarai:stonecutter/1.21from
Exopandora wants to merge 1 commit intoenjarai:stonecutter/1.21from
Conversation
Owner
|
Looks sensible... I'll try it out when I have time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the compatibility with other third person mods for neoforge. The problem is that other mods, such as Shoulder Surfing Reloaded, could use the
setRotation(FF)Vmethod of theCameraclass, which resets the camera roll to 0°. This PR changes the behavior of the method, such that the camera roll is not reset. There may be better ways of doing it 🤷. Related to #203, Exopandora/ShoulderSurfing#285.