Open
Conversation
|
Sider has detected 1 error and 1 warning on analyzing the commit 9035054. If the errors persist even after retrying, the following actions may resolve them:
If you still have problems, feel free to ask us via chat. 💬 You can turn off such notifications if unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
担当者様
お世話になっております。常盤です。
課題をPRで提出いたします。
何卒宜しくお願いします。
クラス設計
Simulator
サービスクラスのような責務
各プランのシミュレートを実行して算出された金額を指定のhashにまとめる
Plan
モデルを意識した責務
各会社のプランが規定している基本料金などのプロパティを持つ
基本料金や重量使用料金を算出するメソッドはこのクラスが持つ
CSVPlan
今回、マスタデータはCSVから取得する形にした
基本的にCSVから読み取る機能をこのクラスに持たせている
Simulatorクラスなどでデータ取り回す場合、基本料金などのメソッドが必要なため、Planクラスへの変換するメソッドを用意した。