Conversation
|
Sider detected 1 error and 2 warnings on analyzing the commit 618852f. We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring If you have problems or questions still, feel free to ask us via chat. 💬 You can turn off this notification if you don't want to receive it from now on. |
yuyasat
reviewed
Mar 16, 2021
Comment on lines
+12
to
+14
| array_plan_info.push({"provider" => "東京電力エナジーパートナー", "plan_name" => "従量電灯B", "price" => 0}) | ||
| array_plan_info.push({"provider" => "Loooop電気", "plan_name" => "おうちプラン", "price" => 0}) | ||
| array_plan_info.push({"provider" => "東京ガス株式会社", "plan_name" => "ずっとも電気１", "price" => 0}) |
Contributor
There was a problem hiding this comment.
この実装ですと、プランが追加されるごとに行を追加し、各メソッド内のロジックも修正しないといけないと思います。
CSVやJSONやYAMLなどを更新すればプログラムコードをいじらなくても良いように修正できますでしょうか？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulaterクラスを実装