Skip to content

Improve repairs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nref merged 12 commits into from
Nov 17, 2024
Merged

Improve repairs #40

nref merged 12 commits into from
Nov 17, 2024

Conversation

@nref
Copy link
Member

@nref nref commented Nov 10, 2024 •
edited
Loading

  • All repairs:

    • Now support FIT files with no records.
      • Getting the activity start and end time is an important part of all repairs.
      • Before, we always tried to get them from the records. But if there are no records, the repair fails.
      • Now, we call back to a variety of sources for getting the activity start and end time.
    • Getting a list of records' total distance now does not crash if there are no records.

  • Additive repairs:

    • If there are no records, we no longer assume there is also no lap, session, or activity mesg. This would result in duplicated lap, session, and activity messages on FIT files that already had them.

  • Backfill repairs:

    • No longer assume that there are no sessions if there are more sport messages than session messages.

Also:

  • Improve file scrolling. Files with no timestamp (0001-01-01) no longer get ignored if there are no other activities. Files no longer get repeated.
  • Hide treadmill lap edit tab. It's confusing since there also the Data > Lap tab. Moreover, the UX is not very good. Will add it back behind a check for treadmill runs.
  • Migrates packaging from from Clowd.Squirrel to Velopack. My hand was forced on this as the author of the former removed the dotnet tool csq, so the build was failing.

nref added 12 commits November 10, 2024 15:04
@nref
Improve repairs.
4644c04 
- All repairs:
  - Now support FIT files with no records.
    - Getting the activity start and end time is an important part of all repairs.
    - Before, we always tried to get them from the records. But if there are no records, the repair fails.
    - Now, we call back to a variety of sources for getting the activity start and end time.
  - Getting a list of records' total distance now does not crash if there are no records.

- Additive repairs:
  - If there are no records, we no longer assume there is also no lap, session, or activity mesg. This would result in duplicated lap, session, and activity messages on FIT files that already had them.
- Backfill repairs:
  - No longer assume that there are no sessions if there are more sport messages than session messages.

Also:
- Improve file scrolling. Files with no timestamp (0001-01-01) no longer get ignored if there are no other activities. Files no longer get repeated.
- Hide treadmill lap edit tab. It's confusing since there also the Data > Lap tab. Moreover, the UX is not very good. Will add it back behind a check for treadmill runs.
@nref
Don't install csq, it doesn't work anymore. It's preinstalled on our …
27086af 
…machine.
@nref
Migrate Windows from csq to vpk
d944a25
@nref
Fix build errors
3dbb6f4
@nref
Migrate app to Velopack. Still support Squirrel
6debc7b
@nref
Contrive a CI run
b07ab23
@nref
Add Setup-Keychain.ps1
6966298
@nref
Add Setup-Keychain.ps1
39248e1
@nref
Build mac version with velopack
ceea1a9
@nref
Make code sign work on MacOS 15 and Xcode 16
66415bf
@nref
Migrate Linux from csq to vpk
191c931
@nref
Update gitignore
6375471
@nref nref merged commit 97b4c01 into main Nov 17, 2024
0 of 3 checks passed
@nref nref deleted the feature/better-repairs branch November 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nref