Fixed errors in ashello_new.asm #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new syntax source file had a non-honored reference to kscan (non-honored: the corresponding copy was missing). I fixed it by copying "keyscan_ea.asm", although for that one to work, I needed to replace the "bl kscan" (branch-and-link) command with "blwp kscan" (branch-and-load-workspace-pointer). Not copying the file had a consequence: the program image (option -i) couldn't be created unless kscan_ea.asm was added to the command line every time. But being other copies already there, why not adding this one so this example is a stand-alone case? Not changing "bl" in favor of "blwp" had another consequence: kscan was actually messing things up and the screen border wasn't really changing in response to pressed keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new syntax source file had a non-honored reference to kscan (non-honored: the corresponding copy was missing).
I fixed it by copying "keyscan_ea.asm", although for that one to work, I needed to replace the "bl kscan" (branch-and-link) command with "blwp kscan" (branch-and-load-workspace-pointer).
Not copying the file had a consequence: the program image (option -i) couldn't be created unless kscan_ea.asm was added to the command line every time. But being other copies already there, why not adding this one so this example is a stand-alone case?
Not changing "bl" in favor of "blwp" had another consequence: kscan was actually messing things up and the screen border wasn't really changing in response to pressed keys.