Adding strip function to remove leading and trailing whitespace from … #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rw-access
reviewed
Sep 25, 2019
rw-access
reviewed
Sep 25, 2019
reidgilman
commented
Jan 13, 2020
Author
reidgilman
left a comment
reidgilman
left a comment
There was a problem hiding this comment.
Hello! I broke strip() into three functions lstrip(), rstrip(), and strip() per your request. I also added tests. I also merged 0.8.0 into my branch, so, this should be a clean merge for you! Please let me know if this looks good or if there are other changes you'd like.
Contributor
|
Awesome, thanks! Can you update the documentation as well? I have a licensing/versioning question internally, and if that all checks out, then we should be good to move forward and merge. I believe this should also be able to make it in by the 3.16 release. If not, then by 3.17. |
Author
|
Documentation updated in 77dd49a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…strings
Issues
Details