Switch to RegisterUnitEvent for raid units #439
+63
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rudimentary implementation to switch from
RegisterEventtoRegisterUnitEvent(with a fallback for unset unit) for allUNIT_*events.This ensures that the events only are processed for the actual displayed unit and not any stray events are processed.
Depending on unit checks down the update line, this should massively improve performance in larger groups and more nameplates on screen, as those would fire global
UNIT_events as well.In this implementation, the
displayedUnitis not set on the first registry, leading to unregister and re-register of the events.I did not spend much time in finding the full setup flow, so this can likely be improved.