Skip to content

Conversation

@atti92
Copy link
Contributor

@atti92 atti92 commented Jun 11, 2024

Tweaks for the other PR to allow click casting with the "spell" attribute instead of the "macrotext" attribute.
Changes:

  • Fix lua errors in a Dragonflight compatible way:
    • GetSpellInfo -> C_Spell.GetSpellInfo
    • GetSpellTexture -> C_Spell.GetSpellInfo
    • GetTexCoordsForRole
    • GetMouseFocus -> GetMouseFoci
  • Fixed ClickCasting:
    • Removed use of "macrotext" when running under TWW beta:
    • Smart resurrection no longer works.
    • Always target feature no longer works.
  • Fixed Range checks:
    • IsSpellInRange -> C_Spell.IsSpellInRange
    • merged evoker branch with other classes.

@atti92 atti92 marked this pull request as ready for review June 12, 2024 18:17
@atti92 atti92 changed the title TWW beta experiments TWW beta compatibility Jun 12, 2024
@enderneko enderneko merged commit 28148cc into enderneko:master Jun 19, 2024
@enderneko
Copy link
Owner

Thank you!!! 💖
finally...

but the feature to make Click-Casting supporting other frames has been disabled (commented out).
will look into it this weekend, not sure about this feature yet

@atti92
Copy link
Contributor Author

atti92 commented Jun 19, 2024

Yeah actually it was meant to be only in this: #132
Somehow I managed to push it also here by mistake :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants