Skip to content

Item descriptions and more compact match history #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrInfiniteExplorer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Item descriptions and more compact match history #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 46 additions & 26 deletions Web/Script/Module/SummonerGames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,25 @@ function getSummonerGamesTable(summoner, games)
{
var titles =
[
'Champion',
'Map',
'Mode',
'Outcome',
'Date',
'Side',
'Spells',
'K',
'D',
'A',
'MK',
'NK',
'Gold',
'Items',
'Level',
'Premade',
'Ping',
'Time in queue',
'Game ID',
['Champion','champion'],
['Map','map'],
['Mode','mode'],
['Outcome','outcome'],
['Date','date'],
['Side','side'],
['Spells','spells'],
['K','kills'],
['D','deaths'],
['A','assissts'],
['MK','minionKills'],
['NK','neutralKills'],
['Gold','gold'],
['Items','items'],
['Lvl','level'],
['Premade','premade'],
['Ping','ping'],
['Queue Time','queueTime'],
['Game ID','gameID'],
];

var container = diverse();
Expand All @@ -35,8 +35,12 @@ function getSummonerGamesTable(summoner, games)
output.add(caption('Games of ' + summoner.SummonerName));

var row = tableRow();
titles.forEach(function(title) {
row.add(tableHead(title));
titles.forEach(function(pair) {
var title = pair[0];
var className = pair[1];
var head = tableHead(title);
head.className = className;
row.add(head);
});
output.add(row);
games.forEach(function(game) {
Expand All @@ -45,12 +49,28 @@ function getSummonerGamesTable(summoner, games)

var items = [];
game.Items.forEach(function(itemId) {
if(itemId == 0)
items.push(icon('Item/Small/Blank.png', 'Unused'));
else
{
if(itemId == 0) {
var itemDiv = diverse();
itemDiv.className = 'item';
itemDiv.add(icon('Item/Small/Blank.png', 'Unused'));
items.push(itemDiv);
} else {

var item = getItem(itemId);
items.push(icon('Item/Small/' + (item.description == 'Unknown' ? 'Unknown' : itemId) + '.png', item.name));
var itemDiv = diverse();
itemDiv.className = 'item';
var _icon = icon('Item/Small/' + (item.description == 'Unknown' ? 'Unknown' : itemId) + '.png', item.name);
itemDiv.add(_icon);

var theList = list();
theList.className = 'itemDesc';
theList.add(listElement(text(item.name)));
theList.add(listElement(text('')));
item.description.split('\n').forEach(function(line) {
theList.add(listElement(text(line)));
});
itemDiv.add(theList);
items.push(itemDiv);
}
});

Expand Down
39 changes: 36 additions & 3 deletions Web/Style/Style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,36 @@ table.statistics td img
table.statistics td.items img
{
margin: 0;
float: left;
}

table.statistics td.items
{
width: 192px;
}

table.statistics ul.itemDesc {
background:#223344;
position:absolute;
width:200px;
display:none;
color:#FFFFFF;
padding:10px;
left:0px;
z-index:2;
//list-style:none outside none;
list-style-type:none;
}

table.statistics .item {
position:relative;
float:left;
}

table.statistics .item:hover .itemDesc {
display:block;
left:32px;
}

table.statistics td.spells img
{
margin: 0;
Expand Down Expand Up @@ -331,21 +353,32 @@ table.graphDescription
margin-bottom: 1.5em;
}

#summonerGames th
{
padding:0 0.2em 0 0.2em;
}

#summonerGames td
{
padding:0 0.3em 0 0.3em;
border: 1px solid black;
}

#summonerGames .date {
min-width:5em;
}
#summonerGames .items {
min-width:192px;
}
#summonerGames
{
text-align: left;
width: 100%;
margin-bottom:500px;
}

#summonerGamesContainer
{
margin: 2em;
min-width: 122em;
}

#returnFromMatchHistory
Expand Down