Skip to content

Conversation

@mharrisb1
Copy link

@mharrisb1 mharrisb1 commented Jan 23, 2025

Summary

Adds httpx-retry to third-party packages page in docs as suggested by issue comment in #108

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@zanieb
Copy link
Contributor

zanieb commented Jan 23, 2025

Do you think it makes sense to add a package here before there's significant community adoption? (I don't feel strongly, but I was surprised to see a week-old package with one release)

@mharrisb1
Copy link
Author

@zanieb up to you. Just following suggestion from issue thread. Feel free to close

@mharrisb1 mharrisb1 closed this Jan 23, 2025
@zanieb
Copy link
Contributor

zanieb commented Jan 23, 2025

I don't mean to be discouraging — other people may feel like it's fine.

@mharrisb1
Copy link
Author

surprised to see a week-old package with one release

This is valid. Maybe there should be a note on adoption threshold, minimum age, or something else to avoid this and other new projects that might become abandonware from being proposed or added.

Or maybe even something as simple as this:

# Third Party Packages
As HTTPX usage grows, there is an expanding community of developers building tools and libraries that integrate with 
- HTTPX, or depend on HTTPX. Here are some of them.
+ HTTPX, or depend on HTTPX. Here are some of the more popular ones.

I shilled the project in the comments so that should be fine for anyone landing there from a Google search that doesn't want to roll their own

@mharrisb1 mharrisb1 mentioned this pull request Feb 12, 2025
@jareks
Copy link

jareks commented Feb 12, 2025

@zanieb please note that in this case not having any package for retries resulted in building two at same time: #108 (comment)

Of course it's up to you to decide if you want to encourage 3rd party package or not but I just wanted to point out there's also a cost of not doing it.

@zanieb
Copy link
Contributor

zanieb commented Feb 14, 2025

It's not really up to me! @tomchristie has the final say and others on the encode team may have different opinions.

I just noted that the package was brand new because it wasn't mentioned in the pull request. I was intending to start a discussion, not make a decision.

I do think it makes some sense to only recommend packages that have demonstrated some level of adoption and stability, but, as I said, I don't feel strongly. There's a "Gist" section so maybe the intent is for it to be very inclusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants