Skip to content

Fix extensions type annotation. #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 8 commits into from
Nov 28, 2024
Merged

Fix extensions type annotation. #3380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68c18e3
Just use default safe=... characters for urlescape
lovelydinosaur Oct 28, 2024
d7c91f9
Cleanup Request method signature
lovelydinosaur Oct 29, 2024
f77117d
Merge branch 'master' into cleanup-method
lovelydinosaur Oct 29, 2024
e099909
Fix extensions annotations
lovelydinosaur Oct 29, 2024
051e371
Merge branch 'master' into fix-extensions-annotation
lovelydinosaur Oct 29, 2024
63973ae
Merge branch 'master' into fix-extensions-annotation
lovelydinosaur Nov 7, 2024
5f0a974
Merge branch 'master' into fix-extensions-annotation
lovelydinosaur Nov 22, 2024
fdd2e91
Merge branch 'master' into fix-extensions-annotation
lovelydinosaur Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpx/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ def __init__(
self.method = method.upper()
self.url = URL(url) if params is None else URL(url, params=params)
self.headers = Headers(headers)
self.extensions = {} if extensions is None else extensions
self.extensions = {} if extensions is None else dict(extensions)

if cookies:
Cookies(cookies).set_cookie_header(self)
Expand Down Expand Up @@ -537,7 +537,7 @@ def __init__(
# the client will set `response.next_request`.
self.next_request: Request | None = None

self.extensions: ResponseExtensions = {} if extensions is None else extensions
self.extensions = {} if extensions is None else dict(extensions)
self.history = [] if history is None else list(history)

self.is_closed = False
Expand Down
5 changes: 2 additions & 3 deletions httpx/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
Iterator,
List,
Mapping,
MutableMapping,
Optional,
Sequence,
Tuple,
Expand Down Expand Up @@ -67,7 +66,7 @@

RequestContent = Union[str, bytes, Iterable[bytes], AsyncIterable[bytes]]
ResponseContent = Union[str, bytes, Iterable[bytes], AsyncIterable[bytes]]
ResponseExtensions = MutableMapping[str, Any]
ResponseExtensions = Mapping[str, Any]

RequestData = Mapping[str, Any]

Expand All @@ -84,7 +83,7 @@
]
RequestFiles = Union[Mapping[str, FileTypes], Sequence[Tuple[str, FileTypes]]]

RequestExtensions = MutableMapping[str, Any]
RequestExtensions = Mapping[str, Any]

__all__ = ["AsyncByteStream", "SyncByteStream"]

Expand Down