Skip to content

#430/conversation header#434

Open
camelPhonso wants to merge 11 commits intodevfrom
#430/conversation-header
Open

#430/conversation header#434
camelPhonso wants to merge 11 commits intodevfrom
#430/conversation-header

Conversation

@camelPhonso
Copy link
Copy Markdown
Contributor

Description

closes #430
relates #431

Creates a new component for the header of conversations with the existing EllipsisMenu.tsx adapted to the new figma design (this component was previously only used inside the ConversationCard component so I just re-styled it slightly).

Note: I left the functionality in the ellipsis menu for whoever takes issue #431 but did most of the styling. In the figma each option in the drop-down menu has an icon in the description but I left that out for now. Ideally, if there's a way we can get those as unicode or something we could display them in the string part of the expected arguments for the EllipsisMenu, otherwise it will require some refactoring.

Files changed

  • ConversationHeader/ - new component and stories file
  • EllipsisIcon.tsx, EllipsisMenu.tsx && EllipsisMenu.stories.tsx - restyled the component and added it to our component library
  • CurrentConversation.tsx - displaying the new header conditionally on breakpoint

UI changes

new conversation header displayed

Changes to Documentation

No documentation updates needed. Expanded the component library with new story files.

Tests

Added some action tests in storybook, left e2e as is

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 27, 2025

Deploy Preview for cool-creponne-3e1272 ready!

Name Link
🔨 Latest commit 74c9aad
🔍 Latest deploy log https://app.netlify.com/projects/cool-creponne-3e1272/deploys/68986d5fe42fb400082bef9b
😎 Deploy Preview https://deploy-preview-434--cool-creponne-3e1272.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camelPhonso
Copy link
Copy Markdown
Contributor Author

I'm not sure why the supabase integration check is complaining, my npx supabase db diff says there are no differences between the local and origin schema. Does anyone in the team have a clue about this?

…avoid changes to types file in codegen

relates #430
@camelPhonso
Copy link
Copy Markdown
Contributor Author

I'm not sure why the supabase integration check is complaining, my npx supabase db diff says there are no differences between the local and origin schema. Does anyone in the team have a clue about this?

Fixed this ☝️ - the ci was installing the 'latest' version of the supabase cli which now apparently prefers to keep 'internals' out of the types.gen.ts so that was causing a difference between that file on HEAD and at the index.

Because of how we've been using the containerised supabase I figured it make sense to keep internals so I adjusted the pipeline to install the same version of the cli that we pinned in our package.json - in any case it makes sense to preserve environment parity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message specific header for mobile view

1 participant