feat(EMULSIF-531): favicon support added #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LSIF-531 * 'main' of github.com:emulsify-ds/emulsify_tools: chore: tigger actions fix: replace commitizen with lint-staged and husky Escaping the css classes added here to prevent xss and other security issues.
Collaborator
|
@josue2591 Nice work on this so far. I added some technical details to the ticket to help refine the implementation. We mostly just need to move the configuration from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a config page to manage the favicons for all the different site themes.
Ticket
https://fourkitchens.clickup.com/t/36718269/EMULSIF-531
How to review this pull request
faviconslink under structurehttps://www.loom.com/share/f394d36ac474403ca7df3d9cb840ef9a?sid=f94941d5-d388-47dc-bb3c-c27aaf6693c0