Add custom mesh parser and update test data due to gmsh bug #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasHoelscher
force-pushed
the
mesh_parser
branch
from
8044735 to
b4bb5b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom mesh parser for gmsh ASCII files of version 2.
The new mesh handling is as follows: If the given mesh if version 2, the new custom mesh parser is used.
Otherwise the gmsh python interface will be used to parse the mesh.
Additionally some changes are made to low level simulation functions: they now work with both 1 or 2 dimensions which makes the implementation of line integrals more general. Now such integrals can be done along arbitrary lines and they don't have to be aligned along the r direction anymore.
The new meshing objects are reorganized in a mesh folder.
The new custom mesh parser has been tested by using the gmsh python interface and version 4 meshes.
Also the test data is updated since there is a bug in the gmsh Python API where the node coordinates are not the same after opening the mesh file.