feat(web/inline-edit): implement a inline editor#1599
Merged
Davidmattei merged 56 commits intoems-project:7.xfrom Mar 19, 2026
Merged
feat(web/inline-edit): implement a inline editor#1599Davidmattei merged 56 commits intoems-project:7.xfrom
Davidmattei merged 56 commits intoems-project:7.xfrom
Conversation
Davidmattei
force-pushed
the
feat/inline-edit
branch
from
4fa43be to
bdab544
Compare
Davidmattei
force-pushed
the
feat/inline-edit
branch
from
32988fc to
d5776d2
Compare
Davidmattei
force-pushed
the
feat/inline-edit
branch
3 times, most recently
from
561cf5d to
128ca67
Compare
Davidmattei
force-pushed
the
feat/inline-edit
branch
3 times, most recently
from
db01b30 to
101744e
Compare
Davidmattei
force-pushed
the
feat/inline-edit
branch
2 times, most recently
from
c769fbf to
bad7a9d
Compare
We want to load the clientHelperBundle vite assets and assets from the hash.
theus77
reviewed
Mar 18, 2026
Member
theus77
left a comment
theus77
left a comment
There was a problem hiding this comment.
How do you handle backend exception in the inline front end app?
Comment on lines
+25
to
+29
| public function getCurrentRevision(): ?Revision | ||
| { | ||
| return \array_find($this->revisions, fn ($revision) => null === $revision->getEndTime()); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
When is it null? When the document is archived I guess?
Member
Author
Current no implementation, we could work toast messages in iframe. |
theus77
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the first iteration of the channel inline editor. Please note that this is currently a Proof of Concept. As we gather feedback on the user experience, the implementation and UI are subject to further refinement and significant changes.
Please note that documentation and final translation keys are omitted from this PR to keep the focus on the core logic. These will be addressed in a follow-up PR as the UI and UX stabilize