fix: immediately unset a core node for all shards, when that core node is down #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
NOTE: please don't merge it, as it doesn't look absolutely worthwhile. The mentioned issues will be fixed in EMQX. |
zmstone
reviewed
Aug 3, 2023
SergeTupchiy
force-pushed
the
EMQX-10703-unset-failed-core-node-immediately
branch
2 times, most recently
from
8cd99c7 to
d9e2f68
Compare
Member
|
lgtm |
…e is down This fix should reduce the risk of delegating a write operation (RPC) to a down core node. Relates to: EMQX-10703, emqx#11310
SergeTupchiy
force-pushed
the
EMQX-10703-unset-failed-core-node-immediately
branch
from
d9e2f68 to
cea3dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should reduce the risk of delegating a write operation (RPC) to a down core node.
Relates to: EMQX-10703, emqx#11310