Skip to content

Refactor guidemaker service to accept any config field #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BlueCutOfficial wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor guidemaker service to accept any config field #90

BlueCutOfficial wants to merge 1 commit into from

Conversation

@BlueCutOfficial
Copy link

@BlueCutOfficial BlueCutOfficial commented Jun 9, 2023

Closes #89

This PR refactors guidemaker service so any field can be read from the guidemaker environment config:

// your-guidemaker-app/config/environment.js

guidemaker: {
  anyConfig: 'Define any config specifics to your Guidemaker Docs',
}

mansona
mansona approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mansona mansona mansona approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make guidemaker service more flexible

2 participants

@BlueCutOfficial @mansona