feat: make MyHistory dates locale rely on uiLang#2002
feat: make MyHistory dates locale rely on uiLang#2002hiepau1231 wants to merge 1 commit intoempathyco:mainfrom
Conversation
- Changed locale resolution to prefer uiLang over lang - Added capitalization of first character in formatted dates - Added comprehensive test cases for uiLang usage and capitalization - Fixes empathyco#791 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hi @victorcg88, I noticed the Root cause: The workflow uses This means any PR from a fork will fail this CI check, regardless of the code quality. Possible solutions (for maintainers):
The code changes themselves are correct and all 10 tests pass locally. Happy to assist in any way I can! Thanks for your time. |
Description
Fixes #791
Makes the
MyHistorycomponent useuiLangfromsnippetConfigfor date formatting, with proper fallback chain:uiLang > lang > locale prop.Changes
my-history.vue:snippetConfig?.lang ?? props.localesnippetConfig?.uiLang ?? snippetConfig?.lang ?? props.localeesreturn lowercase weekday names)should use uiLang from snippetConfig for date formattingshould capitalize the first character of formatted datesshould fallback to lang when uiLang is not providedsnippetConfigwithlang: 'en'Testing