Open
Conversation
wjiamin
reviewed
Aug 4, 2020
Collaborator
wjiamin
left a comment
wjiamin
left a comment
There was a problem hiding this comment.
Some style issues, but algorithm LGTM! I'll let Sailesh approve.
walkthroughs/week-5-tdd/project/src/main/java/com/google/sps/FindMeetingQuery.java
Show resolved
Hide resolved
walkthroughs/week-5-tdd/project/src/main/java/com/google/sps/FindMeetingQuery.java
Show resolved
Hide resolved
walkthroughs/week-5-tdd/project/src/main/java/com/google/sps/FindMeetingQuery.java
Show resolved
Hide resolved
walkthroughs/week-5-tdd/project/src/main/java/com/google/sps/FindMeetingQuery.java
Show resolved
Hide resolved
walkthroughs/week-5-tdd/project/src/main/java/com/google/sps/FindMeetingQuery.java
Show resolved
Hide resolved
| import java.util.List; | ||
| import java.util.Set; | ||
| import java.util.stream.Collectors; | ||
| import java.util.Iterator; |
Collaborator
There was a problem hiding this comment.
This should be sorted
|
|
||
| public Collection <TimeRange> query(Collection <Event> events, MeetingRequest request) { | ||
|
|
||
| this.events = events; |
Collaborator
There was a problem hiding this comment.
Why make these member variables?
| // Check if attendees from event are requested for meeting | ||
| for (String attendee: event.getAttendees()) { | ||
| // Check that attendee is a mandatoryattendee | ||
| if ((request.getAttendees().contains(attendee))) { |
Collaborator
There was a problem hiding this comment.
extra parenthesis (same below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the findMeetingQuery to find the meeting times as well as writing more tests to allow for optional attendees.