Open
Conversation
Keeping up to date with branch undergoing PR
to stay up to date
* Set default order to 0 if input image.dtype is bool * Add test for bool array input * Fix pep8 * Fix imports in test_profile * Address review comments * Add deprecation cycle
can use smaller patch_distance when checking dtype
reduce runtime of non-local means tests
…mentation Improving example on filters
…cikit-image#4235) * Remove copy of tifffile; install from pip. Fixes scikit-image#3578 * Remove references to tifffile from build scripts etc. * Remove references to removed external directory. * Add imagecodecs dependency to read and write compressed TIFF files * Switch to imagecodecs-lite and only test lzw read. It worked in the C implementation before as well. * Try using underscore instead of minus * Revert back to state without compression tests. Co-authored-by: François Boulogne <fboulogne@sciunto.org>
* tiny improvements to haar feature examples * optimization * Update doc/examples/applications/plot_haar_extraction_selection_classification.py
* Fix deltaE cmc close colors * Use alternative fix * Fix imports in test_delta_e.py * Fix test failures * Fix test failures * Fix CI failures * Revert in-place maximum and sqrt * Add comments to the tests Co-authored-by: Riadh <r.fezzani@vitadx.com>
…al-edgecase Fix edgecase bugs in segmentation.relabel_sequential
* started DoG function docstring * First draft working function * added examples to docstring * added DoG tests * incorporating PR feedback * add gallery example * changed sigma variable naming to low and high * added See also sections * window images in plot_dog * fixed typos in DoG function
* [ENH] - Added masked marching cubes. * convert fast_exp to a cython function * Add Leonid Bloch to the CONTRIBUTORS.txt * move fast_exp inside nl_means_denoising * add a test with an empty mask array just to see what happens * [TEST] - Added masked marching cube test [DOC] - Enhanced docstring description [ENH] - Mask array now is in the same axial direction than values * [TEST] - Added test when mask is empty [DOC] - Added assert to guarantee mask and volume has the same shape * [TEST] - Added pytest functionaliy to test Errors [DOC] - Added example of what we mean by region of the volume - Added exaplanation to finite surfaces [CLN] - assert modified by Attribute error to keep consistency with the package [ENH] - Check if masked arg is passed moved to the cython code within the function * [CLN] - Deleted a print statement left from debugging - deleted is not None statement * [BUG] - This must be checked like this otherwise it fails with arrays * [Review] - Removed unreached code in test - Refactored AttributeError to ValueError - Removed duplicated condition * [Review] - Removed code duplication substituted by if mask is None or... - Updated the error test to ValueError * [Review: BUG] - Updated test to ValueError instead AttributeError * [Review: typing] - Using bint in cython * [Review] - New boolean casting. npy_bool * [Review] - Passing the mask argument to all functions * [Review] - Warning for _lorensen method * Update skimage/measure/_marching_cubes_lewiner.py Co-Authored-By: Lars Grueter <lagru@users.noreply.github.com> * [TEST] Adding NonImplemented test and all true test - Change warning to not implemented error * Update skimage/measure/tests/test_marching_cubes.py Co-Authored-By: Riadh Fezzani <rfezzani@gmail.com> * Update skimage/measure/tests/test_marching_cubes.py Co-Authored-By: Riadh Fezzani <rfezzani@gmail.com> * Update skimage/measure/tests/test_marching_cubes.py Co-Authored-By: Riadh Fezzani <rfezzani@gmail.com> * [OPT] Minor optimization for the cases mask is None * [BUG] Fixing error I added trying to optimize * Update skimage/measure/_marching_cubes_lewiner_cy.pyx Co-Authored-By: Riadh Fezzani <rfezzani@gmail.com> * Update skimage/measure/_marching_cubes_lewiner_cy.pyx Wrapping the code at 80 spaces Co-Authored-By: Riadh Fezzani <rfezzani@gmail.com> Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com> Co-authored-by: Jo Walsh <jowalsh@bgs.ac.uk> Co-authored-by: Lars Grueter <lagru@users.noreply.github.com> Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
* Add peaks coordinates sorting according to peak values * Fix the tests * Add documentation * Fix pep8 * Fix docstrings Co-authored-by: Riadh <r.fezzani@vitadx.com>
* feature: pooch: add initial pooch architecture. * feature: pooch: Fixup testing infrastructure for pooch * pooch: add ciede2000 to the registry * pooch: fetch restoration tests * don't add test directories by default to the wheels. * don't package feature data. * feature: pooch: add initial pooch architecture. * feature: pooch: Fixup testing infrastructure for pooch * remove extreneous calls to package unnecessary data_dirs * Update skimage/data/__init__.py Co-Authored-By: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu> * Add feature test data to sdist * Demo of how custom urls can be used * Cleanup how version is computed and modified * Skip cell data if pooch isn't installed. * Update skimage/data/tests/test_data.py * Change how orb descriptor positions are loaded * Install in editable mode for pooch * Touchup io test * Remove additional travis build * Address @Stefan's concern * Typo in data/__init__.py * Improved comments for data/__init__.py * Use legacy datasets in test_collection * Move comment down to restore travis builds * Move comments down to restore travis * Update Value Error Message * Undo the change in travis * Add a docstring for the _fetch function. * Rework the _fetch function logic as expressed by @stefanv. * Update skimage/data/__init__.py * Update skimage/data/_registry.py Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly> * Update skimage/data/__init__.py Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly> * Update skimage/data/__init__.py Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly> * Update skimage/data/__init__.py Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly> * Update skimage/data/__init__.py Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly> * Add ConnectionError to list of exceptions from _fetch * Minor documentation update * Update skimage/data/setup.py Small wording Co-Authored-By: Stefan van der Walt <sjvdwalt@gmail.com> * Make pooch a dependency * Replace schizonts by cells * Move fetch block * Use local import in setup.py * Test pooch using cells3d data * Refactor some tests depending on pooch * don't use a relative import * Add xenial for 3.7 build * 3.7 travis Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu> Co-authored-by: Emmanuelle Gouillart <emma@plot.ly> Co-authored-by: Alexandre de Siqueira <alex.desiqueira@igdore.org> Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
* Replace key del by pop * Refactor find_contour * Fix starts and ends listing * Update comments * Refactor iterate_and_store and rename it to _get_contour_segments * Move array shape check from _get_contour_segments to find_contours * Update skimage/measure/_find_contours.py Co-Authored-By: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu> Co-authored-by: Riadh <r.fezzani@vitadx.com> Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
* added ellipses to random shapes, with simple tests * corrected 1 pylint issue and the max radius for ellipse * limited ellipse mask with image shape * corrected pep8 issues in random shapes ellipses * added blank line in test random shapes * tighter bounding box for the ellipses in random shapes * added ellipse to the list of possible shapes in random shapes doc * added a seed in plot random shapes to guarantee good looking figure * corrected doc mismatch for random seed in random shapes
* Cleanup warning emitted by corner_peaks in tests * Cleanup warnings due to corner_peaks behavior changing in the docstrings * Add todo for corner_peaks
* Fix exposure_adapthist return when clip_limit == 1 * Update skimage/exposure/_adapthist.py Co-Authored-By: François Boulogne <fboulogne@sciunto.org> * Add output dtype doc * Fix tests Co-authored-by: François Boulogne <fboulogne@sciunto.org>
* Added unit test that fails for the current scale implementation * Changed scale implementation to use the determinant, fixed formatting in the unit test Co-authored-by: Danielle <danielle.c.holzberger@jpl.nasa.gov>
… into emmanuelle-user-guide
Author
|
oops... only 889ec17 is interesting. |
emmanuelle
pushed a commit
that referenced
this pull request
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.